[LinuxBIOS] [RFC] Fix up compilation of usb debug in the tree

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Wed Feb 28 14:30:17 CET 2007


Hi,

this patch will fix some compilation breakage for boards with
usb debug configured. So far that's fine.

However, the src/northbridge/amd/amdk8/coherent_ht_car.c change
will break most targets. The u8/u32 typedefs shouldn't be in that
file anyway. Is there any header just for such typedefs?

The ehci.h and it8716f_early_init.c parts can be safely applied
without introducing further breakage.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Regards,
Carl-Daniel

Index: src/include/ehci.h
===================================================================
--- src/include/ehci.h  (Revision 2563)
+++ src/include/ehci.h  (Arbeitskopie)
@@ -1,6 +1,9 @@
 #ifndef EHCI_H
 #define EHCI_H

+/* we need u8/u16/u32 defines from somewhere */
+#include "pc80/vga.h"
+
 struct ehci_caps {
         /* these fields are specified as 8 and 16 bit registers,
          * but some hosts can't perform 8 or 16 bit PCI accesses.
Index: src/superio/ite/it8716f/it8716f_early_init.c
===================================================================
--- src/superio/ite/it8716f/it8716f_early_init.c        (Revision 0)
+++ src/superio/ite/it8716f/it8716f_early_init.c        (Revision 0)
@@ -0,0 +1,15 @@
+#include <arch/romcc_io.h>
+#include "it8716f.h"
+
+static void it8716f_disable_dev(device_t dev)
+{
+       pnp_set_logical_device(dev);
+       pnp_set_enable(dev, 0);
+}
+static void it8716f_enable_dev(device_t dev, unsigned iobase)
+{
+       pnp_set_logical_device(dev);
+       pnp_set_enable(dev, 0);
+       pnp_set_iobase(dev, PNP_IDX_IO0, iobase);
+       pnp_set_enable(dev, 1);
+}
Index: src/northbridge/amd/amdk8/coherent_ht_car.c
===================================================================
--- src/northbridge/amd/amdk8/coherent_ht_car.c (Revision 2563)
+++ src/northbridge/amd/amdk8/coherent_ht_car.c (Arbeitskopie)
@@ -78,8 +78,10 @@

 #define DEFAULT 0x00010101     /* default row entry */

+#if 0
 typedef uint8_t u8;
 typedef uint32_t u32;
+#endif

 #ifndef CROSS_BAR_47_56
        #define CROSS_BAR_47_56 0

-- 
http://www.hailfinger.org/




More information about the coreboot mailing list