[LinuxBIOS] [PATCH] VGA is used before it is initialized

[Stefan Reinauer]

Roman Kononov wrote:
> On 01/17/2007 05:56 PM, Roman Kononov wrote:
>> In the original code vga_inited is set, then run_bios() is
>> called, which does printk(), which is allowed using the VGA.
>>
>> The patch puts vga_inited=1 and run_bios() in the right order.
> 
> For me, this bug resulted in linuxbios hanged.
> 
> When console log level is BIOS_INFO and above, linuxbios accesses
> the video memory of uninitialized VGA hardware, which is bad.
> 

Can you try the attached patch? It's a little less intrusive
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: vgainit.diff
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20070131/93c644af/attachment.ksh>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 250 bytes
Desc: OpenPGP digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20070131/93c644af/attachment.sig>