[LinuxBIOS] [RFC] v3: dts fixes and questions

Uwe Hermann uwe at hermann-uwe.de
Sun Jul 1 02:07:37 CEST 2007


On Sat, Jun 30, 2007 at 04:27:27PM -0700, ron minnich wrote:
> On 6/30/07, Peter Stuge <peter at stuge.se> wrote:
> > On Sat, Jun 30, 2007 at 11:43:20PM +0200, Stefan Reinauer wrote:
> > > So instead of adding enabled; to all device nodes, we should add
> > > disabled to those that we do not want enabled. What do you think?
> >
> > We should definately optimize for the common case whatever it is.
> 
> What I can do is look for a disable property in each node. If it is
> NOT found, emit
> .enabled = 1;
> If it is found,
> .enabled = 0;
> 
> sound ok?

Why not, instead of 'enabled;', use
  enabled="0"
or 
  enabled="1"
then? That has the benefit that you don't have to know what the default
is (enabled or disabled), you know everything you need just by looking
at the dts itself.


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20070701/3cb3d9c7/attachment.sig>


More information about the coreboot mailing list