[LinuxBIOS] [PATCH] v3: Kconfig payload options and README improvements

[Uwe Hermann]

On Thu, May 31, 2007 at 01:43:43AM +0200, Stefan Reinauer wrote:
> > Index: Makefile
> > ===================================================================
> > --- Makefile	(Revision 338)
> > +++ Makefile	(Arbeitskopie)
> >  doxygen:
> >  	$(Q)$(DOXYGEN) util/doxygen/Doxyfile.LinuxBIOS
> >  
> > +payload:
> > +	$(Q)printf "Not yet implemented. This will invoke a helper tool.\n"
> > +
> 
> I'd wait checking this stuff in until we really do something here.

OK, it's commented now.

 
> > -	$(Q)cp $(CONFIG_PAYLOAD) $(obj)/lar.tmp/normal/payload
> > +	$(Q)# TODO: Copy no payload or empty payload if CONFIG_PAYLOAD_NONE.
> > +	$(Q)cp $(CONFIG_PAYLOAD_FILE) $(obj)/lar.tmp/normal/payload
> 
> maybe something like 
> if [ -r $(CONFIG_PAYLOAD_FILE) ]; then cp .... ; fi

Yep, done.


> > -STAGE2_LIB_OBJ       = stage2.o clog2.o mem.o malloc.o tables.o delay.o compute_ip_checksum.o
> > +STAGE2_LIB_OBJ       = stage2.o clog2.o mem.o malloc.o tables.o delay.o \
> > +		       compute_ip_checksum.o
>  
> Uh oh, lots of unrelated whitespace stuff in this patch.

True, it's gone now. I made an extra commit out of that.


Updated patch attached.


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v3_payload_handling.patch
Type: text/x-diff
Size: 9949 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20070603/c299fb36/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20070603/c299fb36/attachment.sig>