[LinuxBIOS] r370 - LinuxBIOSv3/mainboard/emulation/qemu-x86

[Uwe Hermann]

On Wed, Jun 27, 2007 at 09:16:00PM +0200, svn at openbios.org wrote:
> -$(obj)/mainboard/$(MAINBOARDDIR)/statictree.c: $(src)/mainboard/$(MAINBOARDDIR)/dts $(obj)/util/dtc/dtc
> +$(obj)/statictree.h: $(src)/mainboard/$(MAINBOARDDIR)/dts $(obj)/util/dtc/dtc
> +	$(Q)printf "  DTC (static.h)     $(subst $(shell pwd)/,,$(@))\n"
> +	$(Q)$(obj)/util/dtc/dtc -O lbh mainboard/$(MAINBOARDDIR)/dts > $@

Can we drop the "(static.h)" again? It doesn't align in the build
output.


> -/*		southbridge,intel,piix4{
> -			pcipath = "0,0";
> +		southbridge,intel,piix4{

Can we replace "piix4" with "i82371eb"? We should standardize on
the full/correct name for all chipsets.


Nice patch otherwise.

Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20070627/4fc99345/attachment.sig>