[LinuxBIOS] r381 - in LinuxBIOSv3/mainboard: . adl adl/msm800sev amd/norwich emulation/qemu-x86

[Stefan Reinauer]

* Peter Stuge <peter at stuge.se> [070628 01:01]:
> > +	cs5536_early_setup();
> > +
> > +	/* NOTE: must do this AFTER the early_setup!
> > +	 * it is counting on some early MSR setup
> > +	 * for cs5536
> > +	 */
> > +	cs5536_disable_internal_uart();
> 
> Shouldn't it go into _early_setup() then?
> 
> 
> > +	w83627hf_enable_serial(0x2e, 0x30, 0x3f8);
> 
> "Magic" values - shouldn't at least 0x3f8 be a CONFIG_ value?
 
Yeah all these should be deleted from initram. nothing to do with
initram. auto.c heritage!!


> 
> > +	/* Switch from Cache as RAM to real RAM */
> > +	printk(BIOS_SPEW, "Before wbinvd\n");
> > +	__asm__("wbinvd\n");
> > +	printk(BIOS_SPEW, "After wbinvd\n");
> 
> Isn't there already a function for disabling CAR?
> 
> 
> //Peter
> 
> -- 
> linuxbios mailing list
> linuxbios at linuxbios.org
> http://www.linuxbios.org/mailman/listinfo/linuxbios
> 

-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.de  • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866