[LinuxBIOS] r394 - in LinuxBIOSv3: mainboard mainboard/adl/msm800sev mainboard/amd/norwich mainboard/artecgroup mainboard/artecgroup/dbe61 mainboard/emulation/qemu-x86 util/dtc

Stefan Reinauer stepan at coresystems.de
Fri Jun 29 00:07:18 CEST 2007


* Uwe Hermann <uwe at hermann-uwe.de> [070628 23:32]:
> On Thu, Jun 28, 2007 at 06:21:38PM +0200, svn at openbios.org wrote:
> >       mainboard-vendor = "AMD";
> >       mainboard-part-number = "Norwich";
> 
> Wouldn't
> 
>         mainboard-name = "Norwich";
> 
> make more sense? It's not really a part number, it's a name.
 
Yes, definitely!

> > +	  Mainboard specific PCI subsystem device ID.
> 
> Are the subsystem IDs correct for this board or copy+pasted?
 
They are copy and pasted for now :-(

> > +$(obj)/linuxbios.vpd:
> > +	$(Q)printf "  BUILD   DUMMY VPD\n"
> > +	$(Q)dd if=/dev/zero of=$(obj)/linuxbios.vpd bs=256 count=1 $(SILENT)
> > +
> 
> Mainboard-specific? If not it should be in some common Makefile, not in
> every single mainboard Makefile.
 
Potentially mainboard specific. Maybe we should drop this at some point
and choose a different approach. I am not really sure what to do yet.

We have not been using it anywhere so far.

> Can we drop this? A link to the documentation should be in the wiki, not
> every single file. As far as I understand the getpir output is not
> reliable anyway, so we should drop the above note (also from getpir output).
 
One of the plans for v3 should be to drop these files completely and
generate pirq from the dts.
This will need some more work though 


-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.dehttp://www.coresystems.de/




More information about the coreboot mailing list