[LinuxBIOS] [PATCH] Add initial serial output for Via vt82c686

[Uwe Hermann]

Hi,

On Wed, Mar 14, 2007 at 01:52:06AM -0400, Corey Osgood wrote:
> > OK, I tried this code today on an MSI K7T Turbo (MS-6330), which uses
> > the VT82C686B southbridge.
> > 
> > I didn't manage to get serial output with this code, yet. I verified
> > that I can boot Linux with the proprietary BIOS and that I can use
> > minicom for serial connections to another PC (COM1, 115200 bps, 8N1).

Yay, progress.

With the attached patch I get serial output on my board on serial port 1.
I didn't try COM2, yet.

Not quite sure what the initial problem was, but the current code works
for me. Corey, can you please verify whether it still works on your board?
I made some changes here and there (mostly cosmetic), but maybe I broke
some parts of the code, so please verify on your hardware...

If it works (and if you don't spot further problems in the code) I'd say this
can be committed. Please send an Acked-by if the code looks good to you.


> > I guess we can keep the code in src/southbridge/via for now (instead of
> > src/superio/via), I'm still undecided which is better here, but
> > we can always move the code later...
> > 
> 
> If it does get moved, then via vt8231 and vt8235 should also have their
> super i/o functions moved, to avoid confusion and keep consistent.

Yes, the current status is not consistent. We should agree upon one
method to do it. In v1 the vt82c686 in separated into southbridge/superio,
but on v2 the vt8231 (for example) is not separated...


> At line 95 (or around there), try changing it to this, if it still
> doesn't work after the above fix:
> 
> if ( dev == PCI_DEV_INVALID ) {
> 	dev = PCI_DEV(0, 7, 0);
> }

This part worked fine I think, or at least it does in my current patch.

I commented the following lines, they only set values which are already
defaults. I also tested this on real hardware, commenting the lines
doesn't prevent serial output from working...


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vt82c686_serial.patch
Type: text/x-diff
Size: 9025 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20070317/c4d5b32e/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20070317/c4d5b32e/attachment.sig>