[LinuxBIOS] patch: digital logic msm800 sev support

Uwe Hermann uwe at hermann-uwe.de
Sat May 5 00:22:40 CEST 2007


NAK, doesn't build for me:

make[1]: Entering directory `/tmp/v2/targets/digitallogic/msm800sev/msm800sev/fallback'
cp /tmp/v2/src/arch/i386/init/crt0.S.lb crt0.S
make[1]: *** No rule to make target `/tmp/v2/src/mainboard/digitallogic/msm800sev/cache_as_ram_auto.c', needed by `cache_as_ram_auto.inc'.  Stop.
make[1]: Leaving directory `/tmp/v2/targets/digitallogic/msm800sev/msm800sev/fallback'
make: *** [fallback/linuxbios.rom] Error 1


On Fri, May 04, 2007 at 02:41:56PM -0700, ron minnich wrote:
> Index: src/mainboard/digitallogic/msm800sev/Config.lb
> ===================================================================
> --- src/mainboard/digitallogic/msm800sev/Config.lb	(revision 2632)
> +++ src/mainboard/digitallogic/msm800sev/Config.lb	(working copy)
> @@ -15,12 +15,12 @@
>  ## The linuxBIOS bootloader.
>  ##
>  default CONFIG_ROM_PAYLOAD_START = (0xffffffff - ROM_SIZE + ROM_SECTION_OFFSET + 1)
> -default PAYLOAD_SIZE            = ( ROM_SECTION_SIZE - ROM_IMAGE_SIZE )
> +default PAYLOAD_SIZE			= ( ROM_SECTION_SIZE - ROM_IMAGE_SIZE )

No whitespace breakage, please.

  
>  ##
>  ## Compute where this copy of linuxBIOS will start in the boot rom
>  ##
> -default _ROMBASE      = ( CONFIG_ROM_PAYLOAD_START + PAYLOAD_SIZE )
> +default _ROMBASE	  = ( CONFIG_ROM_PAYLOAD_START + PAYLOAD_SIZE )

Ditto.

(and many other places)

  
>  ### Should this be in the northbridge code?
> -mainboardinit arch/i386/lib/cpu_reset.inc
> +#not in serengeti_cheetah mainboardinit arch/i386/lib/cpu_reset.inc

?
 

>  struct chip_operations mainboard_digitallogic_msm800sev_ops = {
> -	CHIP_NAME("DIGITAL-LOGIC MSM800SEV Mainboard")
> +	CHIP_NAME("digitallogip msm800sev mainboard ")
>          .enable_dev = enable_dev,
> +

Nope, please drop this hunk.


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20070505/e88daaa9/attachment.sig>


More information about the coreboot mailing list