[LinuxBIOS] [PATCH] Hide Geode UDC and OTG PCI header

Marc Jones Marc.Jones at AMD.com
Fri May 11 06:07:47 CEST 2007


Peter Stuge wrote:
> On Thu, May 10, 2007 at 05:49:08PM -0600, Marc Jones wrote:
>   
>>  	/* we hope NEVER to be in linuxbios when S3 resumes
>>  	   if (! IsS3Resume()) */
>>     
>
> Stefan beat me to the commit. :)
>
> What about this hope thing? Can you explain the issue? Thanks!
>
>
> //Peter
>
>   
I was hoping not to explain it ;)
Actually, I didn't write that comment. It was before my time. It is a 
placeholder for where some S3 resume stuff needs to skip over normal 
initialization. Right now there isn't any indicator that to take an S3 
path so it is commented out. S3 is something I would like to address in 
coming months. S3 is important to embedded devices like OLPC.
Marc






More information about the coreboot mailing list