[LinuxBIOS] Adding IGEL-316 mainboard

Stefan Reinauer stepan at coresystems.de
Sat May 12 14:28:04 CEST 2007


* Uwe Hermann <uwe at hermann-uwe.de> [070512 09:56]:
> > Index: LinuxBIOSv2/src/mainboard/igel/igel-316/cmos.layout
> > ===================================================================
> > --- /dev/null
> > +++ LinuxBIOSv2/src/mainboard/igel/igel-316/cmos.layout
> 
> Is this needed or used at the moment? Otherwise please drop it for now
> (needs some adaptions in Config.lb otherwise it won't compile any more).
> We can reintroduce it when it's really needed.
 
No, cmos.layout is always needed, except the machine has no battery
backed up clock. Please dont drop this 

 
> > +/**
> > + * @brief This defines CPU's core frequency in kHz
> 
> The @brief is not needed, we configure Doxygen to always use the first sentence
> as short description (JavaDoc-like).
 
does it hurt to do it cleanly anyways?

> > +++ LinuxBIOSv2/documentation/HOWTO/igel-316-howto.txt
> 
> Please drop this here, and create a wiki tutorial containing this info
> (and other instructions how to get LinuxBIOS+Linux running on this
> thin client).
 
I dont think I agree that this should be dropped. I do agree it should
go to the Wiki though. 


-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.dehttp://www.coresystems.de/




More information about the coreboot mailing list