[LinuxBIOS] r2670 - in trunk/LinuxBIOSv2/src/mainboard: asus/p2b bitworks/ims densitron/dpx114 via/epia via/epia-m

svn at openbios.org svn at openbios.org
Tue May 15 12:26:16 CEST 2007


Author: uwe
Date: 2007-05-15 12:26:16 +0200 (Tue, 15 May 2007)
New Revision: 2670

Modified:
   trunk/LinuxBIOSv2/src/mainboard/asus/p2b/auto.c
   trunk/LinuxBIOSv2/src/mainboard/bitworks/ims/auto.c
   trunk/LinuxBIOSv2/src/mainboard/densitron/dpx114/auto.c
   trunk/LinuxBIOSv2/src/mainboard/via/epia-m/auto.c
   trunk/LinuxBIOSv2/src/mainboard/via/epia/auto.c
Log:
Simplify spd_read_byte() functions (trivial).

Signed-off-by: Uwe Hermann <uwe at hermann-uwe.de>
Acked-by: Uwe Hermann <uwe at hermann-uwe.de>



Modified: trunk/LinuxBIOSv2/src/mainboard/asus/p2b/auto.c
===================================================================
--- trunk/LinuxBIOSv2/src/mainboard/asus/p2b/auto.c	2007-05-15 07:11:09 UTC (rev 2669)
+++ trunk/LinuxBIOSv2/src/mainboard/asus/p2b/auto.c	2007-05-15 10:26:16 UTC (rev 2670)
@@ -57,12 +57,9 @@
 	pci_write_config8(0, 0x59, shadowreg);
 }
 
-/* TODO: fix raminit.c to use smbus_read_byte */
 static inline int spd_read_byte(unsigned device, unsigned address)
 {
-	uint8_t c;
-	c = smbus_read_byte(device, address);
-	return c;
+	return smbus_read_byte(device, address);
 }
 
 #include "northbridge/intel/i440bx/raminit.c"

Modified: trunk/LinuxBIOSv2/src/mainboard/bitworks/ims/auto.c
===================================================================
--- trunk/LinuxBIOSv2/src/mainboard/bitworks/ims/auto.c	2007-05-15 07:11:09 UTC (rev 2669)
+++ trunk/LinuxBIOSv2/src/mainboard/bitworks/ims/auto.c	2007-05-15 10:26:16 UTC (rev 2670)
@@ -37,12 +37,9 @@
 	pci_write_config8(0, 0x59, shadowreg);
 }
 
-/* TODO: fix raminit.c to use smbus_read_byte */
 static inline int spd_read_byte(unsigned device, unsigned address)
 {
-	uint8_t c;
-	c = smbus_read_byte(device, address);
-	return c;
+	return smbus_read_byte(device, address);
 }
 
 #include "northbridge/intel/i440bx/raminit.c"

Modified: trunk/LinuxBIOSv2/src/mainboard/densitron/dpx114/auto.c
===================================================================
--- trunk/LinuxBIOSv2/src/mainboard/densitron/dpx114/auto.c	2007-05-15 07:11:09 UTC (rev 2669)
+++ trunk/LinuxBIOSv2/src/mainboard/densitron/dpx114/auto.c	2007-05-15 10:26:16 UTC (rev 2670)
@@ -35,9 +35,7 @@
 #include "southbridge/via/vt8231/vt8231_early_serial.c"
 static inline int spd_read_byte(unsigned device, unsigned address)
 {
-	unsigned char c;
-	c = smbus_read_byte(device, address);
-	return c;
+	return smbus_read_byte(device, address);
 }
 
 #include "northbridge/via/vt8601/raminit.c"

Modified: trunk/LinuxBIOSv2/src/mainboard/via/epia/auto.c
===================================================================
--- trunk/LinuxBIOSv2/src/mainboard/via/epia/auto.c	2007-05-15 07:11:09 UTC (rev 2669)
+++ trunk/LinuxBIOSv2/src/mainboard/via/epia/auto.c	2007-05-15 10:26:16 UTC (rev 2670)
@@ -31,9 +31,7 @@
 
 static inline int spd_read_byte(unsigned device, unsigned address)
 {
-	unsigned char c;
-	c = smbus_read_byte(device, address);
-	return c;
+	return smbus_read_byte(device, address);
 }
 
 #include "northbridge/via/vt8601/raminit.c"

Modified: trunk/LinuxBIOSv2/src/mainboard/via/epia-m/auto.c
===================================================================
--- trunk/LinuxBIOSv2/src/mainboard/via/epia-m/auto.c	2007-05-15 07:11:09 UTC (rev 2669)
+++ trunk/LinuxBIOSv2/src/mainboard/via/epia-m/auto.c	2007-05-15 10:26:16 UTC (rev 2670)
@@ -39,9 +39,7 @@
 
 static inline int spd_read_byte(unsigned device, unsigned address)
 {
-	unsigned char c;
-	c = smbus_read_byte(device, address);
-	return c;
+	return smbus_read_byte(device, address);
 }
 
 #include "northbridge/via/vt8623/raminit.c"





More information about the coreboot mailing list