[LinuxBIOS] [PATCH] Tyan S1846: Device tree fixes

[Uwe Hermann]

On Tue, May 29, 2007 at 03:47:14AM -0400, Corey Osgood wrote:
> Uwe Hermann wrote:
> > +      device pci 7.1 on end		# IDE
> > +      device pci 7.2 on end		# USB
> > +      device pci 7.3 on end		# ACPI
> > +      register "ide0_enable" = "1"
> > +      register "ide1_enable" = "1"
> 
> Shouldn't this be
> 
> device pci 7.1 on 		# IDE
>      register "ide0_enable" = "1"
>      register "ide1_enable" = "1"
> end
> device pci 7.2 on end		# USB
> device pci 7.3 on end		# ACPI

Nope, trying that I get:

===> ERROR: Only chips can have register values

I tested the version in my patch and I can confirm that it works, I
tried disabling IDE0 and FILO didn't find the disk anymore...


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20070529/c3a10f77/attachment.sig>