[LinuxBIOS] r2957 - trunk/util/superiotool

svn at openbios.org svn at openbios.org
Tue Nov 13 10:09:33 CET 2007


Author: uwe
Date: 2007-11-13 10:09:33 +0100 (Tue, 13 Nov 2007)
New Revision: 2957

Modified:
   trunk/util/superiotool/superiotool.c
Log:
Grouping register dumps by 8 register values per group for better readability.
Remove trailing spaces within the register dumps.

Signed-off-by: Frieder Ferlemann <Frieder.Ferlemann at web.de>
Acked-by: Uwe Hermann <uwe at hermann-uwe.de>



Modified: trunk/util/superiotool/superiotool.c
===================================================================
--- trunk/util/superiotool/superiotool.c	2007-11-12 21:02:44 UTC (rev 2956)
+++ trunk/util/superiotool/superiotool.c	2007-11-13 09:09:33 UTC (rev 2957)
@@ -82,9 +82,9 @@
 	const int *idx;
 
 	if (reg_table[i].ldn[j].ldn != NOLDN) {
-		printf("LDN 0x%02x ", reg_table[i].ldn[j].ldn);
+		printf("LDN 0x%02x", reg_table[i].ldn[j].ldn);
 		if (reg_table[i].ldn[j].name != NULL)
-			printf("(%s)", reg_table[i].ldn[j].name);
+			printf(" (%s)", reg_table[i].ldn[j].name);
 		regwrite(port, 0x07, reg_table[i].ldn[j].ldn);
 	} else {
 		printf("Register dump:");
@@ -92,33 +92,33 @@
 
 	idx = reg_table[i].ldn[j].idx;
 
-	printf("\nidx ");
-	for (k = 0; /* Nothing */; k++) {
-		if (idx[k] == EOT)
-			break;
-		printf("%02x ", idx[k]);
+	printf("\nidx");
+	for (k = 0; idx[k] != EOT; k++) {
+		if (k && !(k % 8))
+			putchar(' ');
+		printf(" %02x", idx[k]);
 	}
 
-	printf("\nval ");
-	for (k = 0; /* Nothing */; k++) {
-		if (idx[k] == EOT)
-			break;
-		printf("%02x ", regval(port, idx[k]));
+	printf("\nval");
+	for (k = 0; idx[k] != EOT; k++) {
+		if (k && !(k % 8))
+			putchar(' ');
+		printf(" %02x", regval(port, idx[k]));
 	}
 
-	printf("\ndef ");
+	printf("\ndef");
 	idx = reg_table[i].ldn[j].def;
-	for (k = 0; /* Nothing */; k++) {
-		if (idx[k] == EOT)
-			break;
-		else if (idx[k] == NANA)
-			printf("NA ");
+	for (k = 0; idx[k] != EOT; k++) {
+		if (k && !(k % 8))
+			putchar(' ');
+		if (idx[k] == NANA)
+			printf(" NA");
 		else if (idx[k] == RSVD)
-			printf("RR ");
+			printf(" RR");
 		else if (idx[k] == MISC)	/* TODO */
-			printf("MM ");
+			printf(" MM");
 		else
-			printf("%02x ", idx[k]);
+			printf(" %02x", idx[k]);
 	}
 	printf("\n");
 }





More information about the coreboot mailing list