[LinuxBIOS] [PATCH] Various Tyan S1846 fixes (repost)

Peter Stuge peter at stuge.se
Tue Nov 13 13:43:30 CET 2007


On Tue, Nov 13, 2007 at 12:22:44PM +0100, Uwe Hermann wrote:
> Various small fixes to make the Tyan S1846 match the format of
> the other boards in this patch series.

No reason to hold this up. One comment below, but otherwise:

Acked-by: Peter Stuge <peter at stuge.se>


> -  device pci_domain 0 on
> +  device apic_cluster 0 on		# APIC cluster
> +    chip cpu/intel/slot_2		# CPU (FIXME: It's slot 1, actually)
> +      device apic 0 on end		# APIC
> +    end
> +  end

Please explain this slot_1 vs slot_2 a little more in detail in the
comment.


//Peter




More information about the coreboot mailing list