[LinuxBIOS] patch: alix1c support for v3

[Uwe Hermann]

On Sun, Nov 25, 2007 at 07:07:42PM -0800, ron minnich wrote:
> try again.

Yep, works now. Committed as r521 with some coding style fixes etc.


> > > +int main(void)
> > > +{
> > > +     u8 smb_devices[] =  {
> > > +             DIMM0, DIMM1
> > > +     };
> > > +
> > > +     post_code(POST_START_OF_MAIN);
> >
> > POST_START_OF_MAIN, and...
> >
> >
> > > +void hardware_stage1(void)
> > > +{
> > > +     post_code(POST_START_OF_MAIN);
> >
> > ... POST_START_OF_MAIN again.
> >
> > Shouldn't those be different?
> 
> It's in every board. We have a problem here. Any ideas welcome, but I
> would rather not hold up this commit since it just follows the pattern
> of other boards; we need to fix them all.

Yep.

I think something line POST_START_OF_MAIN / POST_START_OF_HARDWARE_STAGE1
makes sense? The two values must be different, of course.


> > > Index: mainboard/pcengines/alix1c/cmos.layout
> > > ===================================================================
> > > --- mainboard/pcengines/alix1c/cmos.layout    (revision 0)
> > > +++ mainboard/pcengines/alix1c/cmos.layout    (revision 0)
> >
> > Add the common license header to this file, please.
> 
> no other cmos.layout has it. Let's get a template and apply them all,
> but I don't want to hold this specific board up when we need a general
> fix.

Is this (or does it have to be) board-specific anyway? Everybody just
keeps blindly copying it from board to board... Why not have a common
file which each board uses per default, _unless_ it's overridden in dts
for a specific board which needs/wants a different setup?


> > Please don't hardcode POST codes, add them aѕ #defines in post_code.h
> > and document them (i.e. in which situation it is supposed to be used).
> 
> uh oh. There's only one entry in post_code.h :-)

Yeah, this is a TODO ;)

 
> we need to sync up the doc and post_code.h

No, post_code.h _is_ the single place for the documentation (or rather
it will be).


> how about we commit this and take 3 action items:
> 1. fix up post_code.h

Yep.


> 2. Fix all cmos.layout files with license headers

Move one generic file somewhere globally, use that for all boards,
unless overridden.


> 3. fix all main.c and stage1.c to use diffferent post code entries.

Yep.


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org