[LinuxBIOS] Complete and generic 32bit/64bit support

[Myles Watson]

> -----Original Message-----
> From: Ward Vandewege [mailto:ward at gnu.org]
> Sent: Tuesday, November 27, 2007 2:05 PM
> To: Myles Watson
> Cc: 'Jordan Crouse'; 'Linuxbios'
> Subject: Re: [LinuxBIOS] Complete and generic 32bit/64bit support
> 
> Hi Myles,
> 
> On Mon, Nov 26, 2007 at 07:55:48AM -0700, Myles Watson wrote:
> > > Your patch seems ok, except it does not pass -fno-stack-protector
> through
> > > to
> > > mkelfimage anymore, which breaks the build on modern Debian based
> systems.
> > >
> > > Can you fix that?
> >
> > Can you help me know how I broke it?  I don't see anywhere that I
> modified
> > the flags passed to the compiler in mkelfimage.mk.  I also looked at the
> > other changes in the patch, but didn't see anything obvious.  I don't
> have
> > Debian, so it's less obvious for me.
> 
> It's unclear to me as well. Basically buildrom is not perfect yet wrt
> adding
> -fno-stack-protector.
> 
> I suggest we merge your patch now, and fix that later. Other parts of the
> LAB
> payload also don't get -fno-stack-protector as they should.

Sounds good.
Myles

> 
> Thanks,
> Ward.
> 
> --
> Ward Vandewege <ward at fsf.org>
> Free Software Foundation - Senior System Administrator