[LinuxBIOS] Patch quality

[Jordan Crouse]

On 30/10/07 18:14 +0100, Uwe Hermann wrote:
> On Tue, Oct 30, 2007 at 06:07:09PM +0100, Stefan Reinauer wrote:
> > * Jordan Crouse <jordan.crouse at amd.com> [071030 18:03]:
> > > On 30/10/07 03:24 +0100, Stefan Reinauer wrote:
> > > > An important issue will be to get the code compiling. I was not
> > > > successful doing so due to the old ld overlapping sections friend.
> > > 
> > > We've seen this before -  Whats happening here is that the ld script
> > > snippet for .id is going into the ld script after the snippet for .reset,
> > > so to LD, the current pointer appears to jump backwards, and it can't figure
> > > out the math correctly.  The immediately work around is to re-arrange
> > > the order of the .id and the .reset snippets in the script.  I believe this
> > > was fixed in later versions of ld - I can't get it to happen on my trusty
> > > Ubuntu Gutsy box.
> > 
> > What's your ld version?
> > 
> > here:
> > GNU ld (GNU Binutils) 2.17.50.20070726-4 (SUSE Linux)
> 
> FWIW, this is
>   GNU ld (GNU Binutils for Debian) 2.18
> and I can confirm that the build breaks for me too.

Doh!  We've got silliness afoot.  At least we know how to work around it.

Jordan

-- 
Jordan Crouse
Systems Software Development Engineer 
Advanced Micro Devices, Inc.