[LinuxBIOS] [PATCH] v3: fix msm800sev early serial
Uwe Hermann
uwe at hermann-uwe.de
Sun Sep 16 16:55:41 CEST 2007
On Wed, Aug 29, 2007 at 09:18:47PM -0700, ron minnich wrote:
> We have to test this, so please, no acks without a test. I will try to
> test tomorrow.
Any news on this?
> thanks
>
> ron
>
> On 8/29/07, Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net> wrote:
> > The ADL MSM800SEV had SERIAL_DEV hardcoded to 0x30, although it should
> > be W83627HF_SP1 which is 0x2. Fix it and replace magic constants with
> > #define.
> >
> > Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
> >
> > --- LinuxBIOSv3/mainboard/adl/msm800sev/stage1.c (Revision 485)
> > +++ LinuxBIOSv3/mainboard/adl/msm800sev/stage1.c (Arbeitskopie)
> > @@ -33,7 +33,8 @@
> > #include <southbridge/amd/cs5536/cs5536.h>
> > #include <superio/winbond/w83627hf/w83627hf.h>
> >
> > -#define SERIAL_DEV 0x30
> > +#define SERIAL_DEV W83627HF_SP1
> > +#define SERIAL_IOBASE 0x3f8
> >
> > void hardware_stage1(void)
> > {
> > @@ -49,6 +50,6 @@
> > * for cs5536
> > */
> > cs5536_disable_internal_uart();
> > - w83627hf_enable_serial(0x2e, 0x30, 0x3f8);
> > + w83627hf_enable_serial(0x2e, SERIAL_DEV, SERIAL_IOBASE);
> > printk(BIOS_DEBUG, "Done %s\n", __FUNCTION__);
> > }
> >
> >
> > --
> > linuxbios mailing list
> > linuxbios at linuxbios.org
> > http://www.linuxbios.org/mailman/listinfo/linuxbios
> >
>
> --
> linuxbios mailing list
> linuxbios at linuxbios.org
> http://www.linuxbios.org/mailman/listinfo/linuxbios
--
http://www.hermann-uwe.de | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20070916/0aa20f22/attachment.sig>
More information about the coreboot
mailing list