[coreboot] [PATCH] fix stage0_i586.S in v3

[Stefan Reinauer]

Carl-Daniel Hailfinger wrote:
> On 04.04.2008 04:40, Stefan Reinauer wrote:
>   
>> The idea to this patch is from Patrick Georgi but I reimplemented it
>> from scratch since I can't reach the other box for a few days. It
>> fixes stage0_i586.S assembling on the latest official GNU binutils
>> version. Without this patch the compilation fails with:
>>
>>  AS      build/arch/x86/stage0_i586.o
>> /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S: Assembler
>> messages:
>> /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error:
>> missing ')'
[..]
> Sorry, that patch only papers over the bug. If we ever decide to use CAR
> at another location, this will break again and we'll have to duplicate
> some of the code you touched in the patch. I'd prefer to know why a
> division fails, but a subtractoin succeeds.
>   
Why is that code more position dependent than the previous, 
non-compiling code?

While I think, requiring the latest version of binutils (or, any other 
toolchain part, for that matter) is fair, we should not require features 
that do not work in the latest "stable" version but require a snapshot 
release to be installed.

Stefan


-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.de  • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20080404/b07d365b/attachment.sig>