[coreboot] [PATCH] fix stage0_i586.S in v3

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Fri Apr 4 16:54:08 CEST 2008


On 04.04.2008 16:32, Stefan Reinauer wrote:
> Carl-Daniel Hailfinger wrote:
>>> While I think, requiring the latest version of binutils (or, any other
>>> toolchain part, for that matter) is fair, we should not require
>>> features that do not work in the latest "stable" version but require a
>>> snapshot release to be installed.
>>>     
>>
>> It works in older versions. The version you used is buggy. There is no
>> reason not to blacklist that broken version unless someone can prove
>> that the new behaviour is correct according to any spec.
>>   
> That's plain wrong, sorry. I also used 2.17 and the error is the same.
> So the two latest stable versions of binutils don't work with that
> code. You won't get that code to translate unless you use an
> experimental version of binutils (snapshot).

I stand corrected. We fixed one binutils problem with that piece of code
in r3044 of v2, but the patch was not applied to v3. I have corrected
that in r654 of v3.

> So either we get this problem solved differently or I'll have to go
> ahead and check the patch in. Relying on experimental toolchains is
> not an option. Even if your toolchain provider uses experimental
> binutils versions, that's nothing we should enforce.

Can you retest with current HEAD? Thanks!

Regards,
Carl-Daniel




More information about the coreboot mailing list