[coreboot] fam10 AP CAR cleanup

[ron minnich]

On Thu, Apr 24, 2008 at 9:21 AM, Jordan Crouse <jordan.crouse at amd.com> wrote:
>
> On 24/04/08 10:09 -0600, Marc Jones wrote:

>  > Personally, I prefer seeing the & and | values inline so I know exactly
>  > what happened as I read the code. Not having to remember if the function
>  > ~ the mask, BUT I could be convinced that the functions are the right
>  > way to go. I think msr.h would be the correct place. Would you do a
>  > massive search and replace on the entire v2 tree? That would be a lot of
>  > changes. Maybe start in the v3 tree?
>
>  I agree with Marc - the readmsr / modify / writemsr cycle inline is far
>  easier to understand and debug.  See the Geode X driver code for multiple
>  examples of MSR functions gone silly.
>

I'm with Jordan and Marc on this one.

Also, we might want to stop dropping code in .h files. Unless you've
really measured it, we can not assume that inline/macro is somehow
always better than a function call. People have gone out of control
with inlines in other projects :-)

thanks

ron