[coreboot] buildrom bug
mylesgw at gmail.com
Fri Apr 25 17:20:23 CEST 2008
> Hi Myles,
> On Fri, Apr 25, 2008 at 08:49:00AM -0600, Myles Watson wrote:
> > This patch changes the Makefile and the config/payloads/*.conf files so
> > only the payload .mk files that are needed are included. It still
> > kernel.mk, roms.mk and geodevsa.mk every time, but that seemed like a
> > change.
> Great start.
> Don't we need that PAYLOAD_AND_DEP_MK change for every payload?
Did I miss one? Most of the payloads don't have dependencies. The
libpayload ones were the only ones I saw.
> Also; looks like we need one extra small change (see below).
> > Index: Makefile
> > ===================================================================
> > --- Makefile (revision 160)
> > +++ Makefile (working copy)
> > @@ -117,9 +117,10 @@
> > # The following code gets all the make targets, but filters out the
> > # targets which are implicitly set by the platform configuration
> > -MKTARGETS:= $(shell ls $(PACKAGE_DIR)/*/*.mk)
> > +include $(PAYLOAD_AND_DEP_MK)
> > -include $(filter-out $(PACKAGE_DIR)/kernel/% $(PACKAGE_DIR)/coreboot-
> v2/% $(PACKAGE_DIR)/coreboot-v3/%,$(MKTARGETS))
> > +include $(PACKAGE_DIR)/geodevsa/geodevsa.mk
> > +include $(PACKAGE_DIR)/roms/roms.mk
> I needed to add
> +include $(PACKAGE_DIR)/utils/nrv2b.mk
Yep, I missed that one. Fixed.
> This also brings up the question why nrv2b.mk is in the 'utils' directory,
> instead of the $(PACKAGE_DIR)/nrv2b/ directory?
Because it doesn't get included in the ROM?
More information about the coreboot