[coreboot] buildrom bug
Jordan Crouse
jordan.crouse at amd.com
Fri Apr 25 17:40:12 CEST 2008
On 25/04/08 11:37 -0400, Ward Vandewege wrote:
> On Fri, Apr 25, 2008 at 09:20:23AM -0600, Myles Watson wrote:
> > > Don't we need that PAYLOAD_AND_DEP_MK change for every payload?
> >
> > Did I miss one? Most of the payloads don't have dependencies. The
> > libpayload ones were the only ones I saw.
>
> The LAB and kernel payloads?
>
> > > +include $(PACKAGE_DIR)/utils/nrv2b.mk
> >
> > Yep, I missed that one. Fixed.
>
> Great.
>
> > > This also brings up the question why nrv2b.mk is in the 'utils' directory,
> > > instead of the $(PACKAGE_DIR)/nrv2b/ directory?
> >
> > Because it doesn't get included in the ROM?
>
> Hmm, ok, yes.
I guess it all depends on how many directories we want to look at,
and trade that off with how complex the scripts should be. I don't
really have an opinion one way or the other on that.
Jordan
--
Jordan Crouse
Systems Software Development Engineer
Advanced Micro Devices, Inc.
More information about the coreboot
mailing list