[coreboot] [PATCH] [buildrom] more 'make clean' fixes

Ward Vandewege ward at gnu.org
Fri Apr 25 19:18:34 CEST 2008


On Fri, Apr 25, 2008 at 10:49:29AM -0600, Myles Watson wrote:
> I like it.  Could you add coreinfo's .copied and kernel's .header?

Good catch!

> With that change:
> Acked-by: Myles Watson <mylesgw at gmail.com>

Thanks, r167.

> Maybe we should remove the .unpacked stamp on a make distclean too?

That should not be necessary - make distclean will wipe out the entire
STAMP_DIR (well, actually the parent of STAMP_DIR). At least it does for the
packages I checked; if there are where it does not do that, it's a bug.

> > > > Should we automatically do a 'make clean' as part of every 'make'
> > call?
> > >
> > > I'd hate to do that.  When I'm testing the tyan boards I don't want to
> > make
> > > the kernel every time.  Make clean removes the entire deploy directory.
> > 
> > Yeah. You're right.
> > 
> > > Another problem we have is that we never check to see if
> > > deploy/$(PAYLOAD)-payload.elf is old.  This leads to some unexpected
> > > behavior for me.
> 
> This may have been a side effect of something else.  I'll check it again
> after we get some of these patches in.

Great.

Thanks,
Ward.

-- 
Ward Vandewege <ward at fsf.org>
Free Software Foundation - Senior System Administrator




More information about the coreboot mailing list