[coreboot] flashrom: handle NULL function pointers
Peter Stuge
peter at stuge.se
Mon Apr 28 14:45:13 CEST 2008
One down.
//Peter
-------------- next part --------------
flashrom: Handle NULL probe, erase and write function pointers in the
flashchips table. The read pointer was already checked properly.
Signed-off-by: Peter Stuge <peter at stuge.se>
Index: flashrom.1.nullptrs/flashrom.c
===================================================================
--- flashrom.1.nullptrs/flashrom.c (revision 3272)
+++ flashrom.1.nullptrs/flashrom.c (working copy)
@@ -111,6 +111,11 @@
}
printf_debug("Probing for %s %s, %d KB: ",
flash->vendor, flash->name, flash->total_size);
+ if (!flash->probe) {
+ printf_debug("failed! flashrom has no probe function for this flash chip.\n");
+ flash++;
+ continue;
+ }
size = flash->total_size * 1024;
@@ -425,6 +430,10 @@
if (erase_it) {
printf("Erasing flash chip\n");
+ if (!flash->erase) {
+ fprintf(stderr, "Error: flashrom has no erase function for this flash chip.\n");
+ return 1;
+ }
flash->erase(flash);
exit(0);
} else if (read_it) {
@@ -493,8 +502,13 @@
// ////////////////////////////////////////////////////////////
- if (write_it)
+ if (write_it) {
+ if (!flash->write) {
+ fprintf(stderr, "Error: flashrom has no write function for this flash chip.\n");
+ return 1;
+ }
ret |= flash->write(flash, buf);
+ }
if (verify_it)
ret |= verify_flash(flash, buf);
More information about the coreboot
mailing list