[coreboot] Patch for ST M50FLW080A support (now with Signed-off-by - Line)
stepan at coresystems.de
Tue Apr 29 02:09:08 CEST 2008
Carl-Daniel Hailfinger wrote:
> On 28.04.2008 19:56, Stefan Reinauer wrote:
>> Claus Gindhart wrote:
>>> The generic jedec.c does not work for the ST M50FLW flash
>>> devices, because they need an unlock command first.
>>> For this reason, ST M50FLW support is moved to a new HW support
>>> module, because any change in jedec.c
>>> would bear the risk to cause problems with the already
>>> supported devices.
>>> It's already tested with ST M50FLW080A; the other
>>> chips of this family i dont have available, so i couldnt
>>> test it.
>>> Signed-off-by: Claus Gindhart <claus.gindhart at kontron.com>
>> Due to your commit message and the many TODOs in jedec.c that file was
>> ommitted. The rest is commited in r3274.
>> Thank you very much for your contribution.
> This was a bit too fast. The probe function looks like an exact copy of
> probe_jedec and can be dropped. The flashrom restructuring I have in
> mind benefits from a reduction of probe functions and allows
> faster+generic probing.
While I don't think probing speed is anywhere close to crucial at the
moment, your patches are of course welcome.
Until they appear, I don't see any problems with the current commit.
More information about the coreboot