[coreboot] [PATCH] [RFC] v3: CS5536 cleanup

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Fri Aug 1 20:15:34 CEST 2008


Ping?

Regards,
Carl-Daniel

On 10.07.2008 20:31, Carl-Daniel Hailfinger wrote:
> On 10.07.2008 16:48, Stefan Reinauer wrote:
>   
>> Carl-Daniel Hailfinger wrote:
>>   
>>     
>>> On 04.07.2008 01:32, Carl-Daniel Hailfinger wrote:
>>>   
>>>     
>>>       
>>>> - Improve VPCI hiding debug message and add doxygen comments.
>>>> - Replace a hand-crafted open-coded VPCI hiding sequence.
>>>>
>>>> Build tested on all relevant targets.
>>>>
>>>> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
>>>>
>>>>       
>>>>         
>>> And as attachment for Ron.
>>>     
>>>       
>> I suggest using pci_write_config32 to register 0x7C, because that is
>> exactly what this does.
>>   
>>     
>
> The one call I converted is the only one which does not use register
> 0x7C. All other calls will be using a to-be written function which takes
> a struct device * and uses pci_write_config32. Besides that, as long as
> we offer the unwanted_vpci array in the dts, the function in my patch is
> essential.
>
> If there are workable alternatives, I'd like to hear about them.
>
> Regards,
> Carl-Daniel
>   

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: linuxbios3_cs5536_cleanup05.diff
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20080801/a61d9657/attachment.ksh>


More information about the coreboot mailing list