[coreboot] [PATCH] v3: verbose GeodeLX register printing

Peter Stuge peter at stuge.se
Fri Aug 1 21:02:46 CEST 2008


On Fri, Aug 01, 2008 at 08:55:40PM +0200, Carl-Daniel Hailfinger wrote:
> The Geode LX RAMinit code already has textual register names in the
> debug routine. Use them for printout.
> 
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Sure.

Acked-by: Peter Stuge <peter at stuge.se>


> Index: LinuxBIOSv3-dbe62/northbridge/amd/geodelx/raminit.c
> ===================================================================
> --- LinuxBIOSv3-dbe62/northbridge/amd/geodelx/raminit.c	(Revision 707)
> +++ LinuxBIOSv3-dbe62/northbridge/amd/geodelx/raminit.c	(Arbeitskopie)
> @@ -41,7 +41,6 @@
>   * compare to a factory BIOS setting.
>   * @param level printk level
>   */
> -
>  void dumplxmsrs(void)
>  {
>  	const static unsigned long msrs[] = {
> @@ -64,13 +63,15 @@
>  	};
>  	int i;
>  
> -	for(i = 0; i < sizeof(msrs)/sizeof(msrs[0]); i++){
> +	for (i = 0; i < ARRAY_SIZE(msrs); i++) {
>  		struct msr msr;
>  		msr = rdmsr(msrs[i]);
> -		printk(BIOS_DEBUG, "(%lx): %x.%x\n",  msrs[i], msr.hi, msr.lo);
> +		printk(BIOS_DEBUG, "%s (%lx): %x.%x\n",  msrnames[i], msrs[i],
> +			msr.hi, msr.lo);
>  	}
>  
>  }
> +
>  /**
>   * Halt and Catch Fire. Print an error, then loop, sending NULLs on
>   * serial port, to ensure the message is visible.




More information about the coreboot mailing list