[coreboot] r708 - coreboot-v3/northbridge/amd/geodelx
svn at coreboot.org
svn at coreboot.org
Fri Aug 1 21:39:14 CEST 2008
Author: hailfinger
Date: 2008-08-01 21:39:13 +0200 (Fri, 01 Aug 2008)
New Revision: 708
Modified:
coreboot-v3/northbridge/amd/geodelx/raminit.c
Log:
The Geode LX RAMinit code already has textual register names in the
debug routine. Use them for printout.
Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
Acked-by: Peter Stuge <peter at stuge.se>
Modified: coreboot-v3/northbridge/amd/geodelx/raminit.c
===================================================================
--- coreboot-v3/northbridge/amd/geodelx/raminit.c 2008-08-01 18:03:18 UTC (rev 707)
+++ coreboot-v3/northbridge/amd/geodelx/raminit.c 2008-08-01 19:39:13 UTC (rev 708)
@@ -41,7 +41,6 @@
* compare to a factory BIOS setting.
* @param level printk level
*/
-
void dumplxmsrs(void)
{
const static unsigned long msrs[] = {
@@ -64,13 +63,15 @@
};
int i;
- for(i = 0; i < sizeof(msrs)/sizeof(msrs[0]); i++){
+ for (i = 0; i < ARRAY_SIZE(msrs); i++) {
struct msr msr;
msr = rdmsr(msrs[i]);
- printk(BIOS_DEBUG, "(%lx): %x.%x\n", msrs[i], msr.hi, msr.lo);
+ printk(BIOS_DEBUG, "%s (%lx): %x.%x\n", msrnames[i], msrs[i],
+ msr.hi, msr.lo);
}
}
+
/**
* Halt and Catch Fire. Print an error, then loop, sending NULLs on
* serial port, to ensure the message is visible.
More information about the coreboot
mailing list