[coreboot] [PATCH] [flashrom] Numony support

Peter Stuge peter at stuge.se
Sat Aug 2 21:58:43 CEST 2008


On Sat, Aug 02, 2008 at 05:04:40PM +0200, Stefan Reinauer wrote:
> Add support for Numonyx M25PE80. This chip requires to be erased
> blockwise, as the c7 method is unreliable, either for ICH7 or for
> this chip.
> 
> Signed-off-by: Stefan Reinauer <stepan at coresystems.de>

Acked-by: Peter Stuge <peter at stuge.se>


On Sat, Aug 02, 2008 at 05:12:19PM +0200, Stefan Reinauer wrote:
> >>erased blockwise
> >..
> >>+int spi_chip_erase(struct flashchip *flash);
> >
> >Please change the function names to match the functionality.
> 
> It erases the chip?
> 
> Since it does not do blockwise erase on all chipsets, pretending it
> did would be bad.

Right you are. This is the best solution at the moment!


//Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20080802/adc72981/attachment.sig>


More information about the coreboot mailing list