[coreboot] [flashrom] convert lb_ to cb_

Uwe Hermann uwe at hermann-uwe.de
Fri Aug 8 23:11:46 CEST 2008


On Fri, Aug 08, 2008 at 10:21:55PM +0200, Peter Stuge wrote:
> On Fri, Aug 08, 2008 at 10:00:39AM -0700, Sean Nelson wrote:
> > -static inline uint64_t unpack_lb64(struct lb_uint64 value)
> > +static inline uint64_t unpack_lb64(struct cb_uint64 value)
> >  {
> 
> You missed the function names, but the rest looks good.
> 
> Can you send a new patch with that fixed?

Also, I'd rather not add an additional (C) for this patch, simple
"fix typo"- or "whitespace-fixes"-style patches such as this don't
warrant adding a (C) to the code (IMHO). (the other parts of your
flashrom changes do, of course, as they're non-cosmetic and
non-trivial).


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org




More information about the coreboot mailing list