[coreboot] v3 patch: include

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Tue Aug 12 04:10:27 CEST 2008


On 12.08.2008 02:00, ron minnich wrote:
> Make some things (die, mem*, resourcemap code, option code) SHARED. 
> The option code is tricky as it is used by standalone code. If you include
> that file and you are standalone, you now have to define STANDALONE
> (is there a better way?)
>
> Change the cpuid to be a 24-byte string instead of 3 u32s. 
>
> Make the CPUID usage PIC-safe by not using %ebx.
>
> Signed-off-by: Ronald G. Minnich <rminnich at gmail.com>
>   

Please keep in mind that every shared function bloats the image.

I assume you have build tested this change on all targets. It has the
potential to blow up on Geode.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the coreboot mailing list