[coreboot] v2: is this a bug ? (in device_util.c)

ron minnich rminnich at gmail.com
Tue Aug 12 06:25:25 CEST 2008


On Mon, Aug 11, 2008 at 7:30 PM,  <JasonZhao at viatech.com.cn> wrote:
> Hardwaremain()-> dev_configure();-> void root_dev_read_resources(device_t
> root) ->
>
> void compact_resources(device_t dev)->
>
> memmove(resource, resource + 1, dev->resources - i);
>
> The third parameter should be (dev->resources-I)* sizeof(*resource)
>

that's a puzzler. I think you are right but ... how did this EVER
work. Only if this code was
never really exercised.

same bug is in v3, btw.

Wow. I am impressed with this catch!

ron




More information about the coreboot mailing list