[coreboot] [RFC][PATCH] v3: kill duplicated function
c-d.hailfinger.devel.2006 at gmx.net
Wed Aug 27 03:22:08 CEST 2008
On 26.08.2008 20:06, Uwe Hermann wrote:
> On Mon, Aug 25, 2008 at 08:03:04PM -0700, ron minnich wrote:
>> On Mon, Aug 25, 2008 at 7:54 PM, Carl-Daniel Hailfinger
>>> - Kill it in the southbridge code and use mainboard code only.
>>> - Rename the southbridge one and call it from mainboard code
>> This is very sensible to me.
> Ack (if the code is not board-specific; I assume that it's probably not,
> or boards can override the generic code if needed).
How to read the SPD ROMs is entirely mainboard-specific. For Geode,
there are two functions:
- one reads SPD via SMBus
- the other one reads fake SPD from an array.
Selecting the right function is the challenge here. Ron once complained
that v2 was "too greppy". Adding another layer of indirection
(southbridge function renaming) would cause exactly that greppiness.
And the function we're talking about is a one-liner. I think we can live
with duplicating it between mainboard dirs. Desktop boards with
multiplexes SMBus will have the same problem.
Ron, unless you have strong objections, I'll commit the original patch
with southbridge function removal.
More information about the coreboot