[coreboot] [PATCH] flashrom: Use explicit read function

Peter Stuge peter at stuge.se
Wed Dec 10 12:08:43 CET 2008


Carl-Daniel Hailfinger wrote:
> Flashrom assumes that the flash chip contents are available via
> mmap if no read function is defined. This special case is handled
> in lots of places all over the code.
> 
> Remove the special case and supply a jedec_read function.

This of course has absolutely nothing to do with JEDEC.

I believe Stephan already created read_flash() in flashrom.c which
does exactly the same thing. Just use that. I've promised to attach
his patch to a ticket against the 1.1 milestone.

Nak in short, at the very least the name and which file it's in is
all wrong.


//Peter




More information about the coreboot mailing list