[coreboot] v3 Kontron warnings
Myles Watson
mylesgw at gmail.com
Wed Dec 10 19:05:15 CET 2008
On Wed, Dec 10, 2008 at 11:02 AM, Uwe Hermann <uwe at hermann-uwe.de> wrote:
> On Wed, Dec 10, 2008 at 09:57:21AM -0700, Myles Watson wrote:
> > This patch fixes some warnings in the Kontron build and a little bit of
> > whitespace.
> >
> > Signed-off-by: Myles Watson <mylesgw at gmail.com>
> >
> > Thanks,
> > Myles
>
> > Index: svn/northbridge/intel/i945/raminit.c
> > ===================================================================
> > --- svn.orig/northbridge/intel/i945/raminit.c
> > +++ svn/northbridge/intel/i945/raminit.c
> > @@ -1070,7 +1070,7 @@ static void sdram_rcomp_buffer_strength_
> > };
> >
> > const u8 * strength_multiplier;
> > - const u8* const * slew_group_lookup;
> > + const u8 * slew_group_lookup;
>
> That should be
>
> > + const u8 *slew_group_lookup;
fixed.
>
> > -static void set_subsystem(struct device * dev, u16 vendor, u16 device)
> > +static void set_subsystem(struct device * dev, unsigned vendor, unsigned
> device)
>
> Nope, u16 is the correct one, please don't change in this direction,
> rather change more *int* to u8/u16/u32 where appropriate.
That was Ron's comment too. Fixed.
> > Index: svn/mainboard/kontron/986lcd-m/stage1.c
> > ===================================================================
> > --- svn.orig/mainboard/kontron/986lcd-m/stage1.c
> > +++ svn/mainboard/kontron/986lcd-m/stage1.c
> > @@ -207,7 +207,6 @@ void hardware_stage1(void)
> > {
> > void early_superio_config_w83627thg(void);
> > void ich7_enable_lpc(void);
> > - int boot_mode = 0;
>
> Not used/needed?
>
Not used.
Thanks for the quick review. Sorry our mails crossed.
Myles
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20081210/27cdefb5/attachment.html>
More information about the coreboot
mailing list