[coreboot] [PATCH][v3] Check that CAR and ROM areas don'tcollide
c-d.hailfinger.devel.2006 at gmx.net
Wed Dec 10 23:11:59 CET 2008
On 10.12.2008 23:02, Myles Watson wrote:
> On Wed, Dec 10, 2008 at 2:57 PM, Carl-Daniel Hailfinger
> <c-d.hailfinger.devel.2006 at gmx.net> wrote:
>> You're welcome. I admit that off-by-one errors are pretty hard to spot
>> and your code really looked correct at the first glance.
>> We have an old saying at my university about such bugs: "Programmers are
>> either off by one or by a factor of two." It happened to me often
>> enough. ;-)
>> On 10.12.2008 22:51, Corey Osgood wrote:
>>> Per Segher's email I'd prefer to go with
>>> Carl-Daniel's original suggestion of using 0x100000000.
> Sounds good.
> Even though the Kconfig solution proposed was ugly, could we think of a
> different one that would still live in Kconfig. It seems a lot nicer to
> catch it during configuration than during the build.
I hope to move CAR settings away from Kconfig. It was needed to store
these settings in Kconfig when we had no processor-specific include
files, but that's no longer the case. I'll send a patch.
More information about the coreboot