[coreboot] Fwd: [RFC] Here we go... the SLOF biosemu forcoreboot-v3

[Myles Watson]

On Tue, Dec 16, 2008 at 6:14 AM, Pattrick Hueper <phueper at hueper.net> wrote:

> Hi,
>
> On Mon, Dec 15, 2008 at 7:28 PM, Peter Stuge <peter at stuge.se> wrote:
> > On the other hand, it is of course expected to have descriptive
> > file names, which makes biosemu.c a good name for a file doing BIOS
> > emulation in any case.
> >
> ...
> >
> > It could go into Kconfig but users should not be bothered with it.
> > Maybe make it changeable for experts only.
> >
>
> here are two more patches,
>
> - rename biosemu to YABEL in Kconfig, CONFIG variables and directory
> - make the virtual memory location and size editable in Kconfig


I don't think the size should be a config option.  Why should the size
change?  If it is to add features, the features should be the config
options.


> I couldn't figure out a way to tell Kconfig that the VIRTMEM variables
> depend on EXPERT to be visible in menu, but still must be set in
> .config if EXPERT is not set but YABEL is set.
> Thus i introduced a workaround in yabel/compat/functions.c to detect
> wether the CONFIG_xxx variables are defined and if they are not
> defined, default to 16MB/1MB size.
> In this workaround i dont like the fact, that the defaults (16MB for
> location, 1MB for size) are set twice... once in Kconfig if EXPERT and
> once in yabel/compat/functions.c if !EXPERT and thus no CONFIG_xxx
> variables. Any recommendations for that problem?


I would take out the default setting in Kconfig.  If the person has to be an
expert to change it, and they're changing it, there shouldn't be a default.

Thanks,
Myles
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20081216/7c5e9bcd/attachment.html>