[coreboot] v3 patches and question

[Marc Jones]

On Wed, Dec 17, 2008 at 1:42 PM, Myles Watson <mylesgw at gmail.com> wrote:
> serengeti.diff and dtc-links.diff make serengeti find all of its devices
> correctly.
>
> serengeti.diff
> - takes out the multiple links for the Opteron (they weren't working
> correctly)
> - adds the 8132 devices and makes them pci_a so they don't conflict with the
> 8111
> - corrects the disabled flags (I think we should have a build error
> somewhere when there are incorrect flags)
> - moves the lpc device to the lpc bus
> - adds back in the second Opteron
>
> Signed-off-by: Myles Watson <mylesgw at gmail.com>
>

Acked-by: Marc Jones <marcj303 at gmail.com>
But what about amd8151?

> dtc-links.diff
> - removes multiple link code.  I know someone could probably fix it, but
> it's broken and not needed for now.
> It made siblings that were bridges be multiple links on the same device.
> That messed a lot of things up for Serengeti.  I think it could be changed
> so that siblings with the same PCI identifier that are bridges become
> multiple links.  It's ugly, though.
>
> Signed-off-by: Myles Watson <mylesgw at gmail.com>
>

So how does this allow amd8151 to be on a separate link?

> pci_match_v2.diff:
> Even though Serengeti seems to work the same as v2, it still won't show
> anything on the display.  The VGA device is not claiming the 0xa0000-0xc0000
> address space.  Since SimNOW is a simulator, I trace the memory space to see
> that the VGA writes are going to RAM.
>
> I put this in to make the PCI config space bit-for-bit identical at VGA ROM
> run.  It still doesn't work. :(  Any help would be appreciated.

You have probably look but amdk8_create_vga_resource is working correctly?

Marc