[coreboot] [RFC] Error out on implicit declarations

[Bao, Zheng]

My patch about acpi_tables.c has nothing to do with implicit
declaration. But it also output warnings and should be fixed. I agree
with other improvement you made.

--- coreboot-v2-org/src/mainboard/amd/dbm690t/acpi_tables.c
2008-12-02 02:56:38.000000000 +0800
+++ ../coreboot-v2/src/mainboard/amd/dbm690t/acpi_tables.c
2008-12-19 15:35:29.000000000 +0800
@@ -133,12 +133,12 @@
 	u32 *v;
 	struct cpuid_result cpuid1;
 
-	typedef struct power_limit_encoding {
+	typedef struct _power_limit_encoding {
 		u8 socket_type;
 		u8 cmp_cap;
 		u8 pwr_lmt;
 		u32 power_limit;
-	};
+	} power_limit_encoding;
 	u8 Max_fid, Max_vid, Start_fid, Start_vid, Min_fid, Min_vid;
 	u16 Max_feq;
 	u8 Pstate_fid[10];
@@ -167,7 +167,7 @@
 	u32 new_package_length;
 	u8 sum, checksum;
 	u32 fid_multiplier;
-	static struct power_limit_encoding TDP[20] = {
+	static power_limit_encoding TDP[20] = {
 		{0x11, 0x0, 0x8, 62},
 		{0x11, 0x1, 0x8, 89},
 		{0x11, 0x1, 0xa, 103},

-----Original Message-----
From: Carl-Daniel Hailfinger [mailto:c-d.hailfinger.devel.2006 at gmx.net] 
Sent: Tuesday, December 23, 2008 10:31 AM
To: Bao, Zheng
Cc: coreboot at coreboot.org
Subject: Re: [coreboot] [RFC] Error out on implicit declarations

Hi Zheng,

sorry for the delayed response.

On 23.12.2008 03:02, Bao, Zheng wrote:
> Carl-Daniel,
> Can you acked-by these patches for implicit declaration?
>   

The SB600 patch is

Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
and committed in revision 3837.


I think we can make the DBM690T patch shorter. What do you think?

Fix implicit declarations in the AMD DBM690T target by using the right
header files.

Signed-off-by: Carl-Daniel Hailfinger
<c-d.hailfinger.devel.2006 at gmx.net>

Index: LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/fadt.c
===================================================================
--- LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/fadt.c
(Revision 3837)
+++ LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/fadt.c
(Arbeitskopie)
@@ -25,6 +25,8 @@
 #include <console/console.h>
 #include <arch/acpi.h>
 #include <arch/io.h>
+#include <device/device.h>
+#include <../southbridge/amd/sb600/sb600.h>
 
 /*extern*/ u16 pm_base = 0x800;
 /* pm_base should be set in sb acpi */
Index: LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/mainboard.c
===================================================================
--- LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/mainboard.c
(Revision 3837)
+++ LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/mainboard.c
(Arbeitskopie)
@@ -25,6 +25,7 @@
 #include <cpu/x86/msr.h>
 #include <cpu/amd/mtrr.h>
 #include <device/pci_def.h>
+#include <../southbridge/amd/sb600/sb600.h>
 #include "chip.h"
 
 #define ADT7461_ADDRESS 0x4C
@@ -34,6 +35,8 @@
 extern int do_smbus_read_byte(u32 smbus_io_base, u32 device, u32
address);
 extern int do_smbus_write_byte(u32 smbus_io_base, u32 device, u32
address,
 			       u8 val);
+extern void lb_add_memory_range(struct lb_memory *mem, uint32_t type, 
+				uint64_t start, uint64_t size);
 #define ADT7461_read_byte(address) \
 	do_smbus_read_byte(SMBUS_IO_BASE, ADT7461_ADDRESS, address)
 #define ARA_read_byte(address) \


-- 
http://www.hailfinger.org/