[coreboot] Coreboot-v2 patch rom names

Jordan Crouse jordan.crouse at amd.com
Tue Feb 5 22:48:51 CET 2008


On 05/02/08 14:20 -0700, Myles Watson wrote:
> This patch changes all rom names that aren't coreboot.rom in Config.lb files.
> 
> I think that since the directory specifies the architecture and the
> board, it is redundant information to name it something else, and it
> makes it more difficult to automate the build process (buildrom).
> 
> In buildrom we should just use Config-options.lb files instead of
> patching or keeping our own.  It just adds more to maintain, with very
> little benefit.  The correct place for Config.lb files is in the
> coreboot-v2 tree.
> 
> The next patch would add Config-lab.lb files for each architecture
> supported by buildrom.  Another patch would change buildrom to stop
> patching Config.lb files.  There is already a CBV2_CONFIG variable
> that would work nicely for selecting the correct file.
> 
> Comments?
> 
> Signed-off-by: Myles Watson <myles at pel.cs.byu.edu>
Acked-by: Jordan Crouse <jordan.crouse at amd.com>

Are you going to patch buildrom to remove the ROM name stuff too?  If so,
I ack it now if I don't see it until later.

Jordan

-- 
Jordan Crouse
Systems Software Development Engineer 
Advanced Micro Devices, Inc.






More information about the coreboot mailing list