[coreboot] flashrom: Add board enable for VIA EPIA SP.
Luc Verhaegen
libv at skynet.be
Wed Feb 6 19:59:48 CET 2008
On Wed, Feb 06, 2008 at 07:05:46PM +0100, Uwe Hermann wrote:
> On Tue, Feb 05, 2008 at 09:47:18PM +0100, Luc Verhaegen wrote:
> > + dev = pci_dev_find(0x1106, 0x3227); /* VT8237 ISA bridge */
>
> Is this really meant to be VT8237 or should it be VT8237R?
Hrm... Took the disk out already :( Chip itself is covered by a
heatsink.
The machine i needed to flash the bios for has a VT8237A, and this has
0x3337 for the ISA bridge.
pciids.sf.net has the SP device down for a plain VT8237, confirms
the VT8237A and has 0x3372 for VT8237S.
I'll guess i'll just give in and install a new suse for the p4m900 and
return the other disk to its original owner (the SP).
> > + val &= ~0x80;
>
> Just some cosmetics: I personally find the
>
> val &= ~(1 << 7);
>
> notation clearer for manipulating bits.
Taste :)
> If nobody complains I'll commit with the changes above.
Let me get back to you on the identification of the devices.
Luc Verhaegen.
SUSE/Novell X Driver Developer.
More information about the coreboot
mailing list