[coreboot] NEW PATCH -- please ignore previous PIRQ patch

[Corey Osgood]

On Feb 9, 2008 2:36 AM, ron minnich <rminnich at gmail.com> wrote:

> Interrupts are up and working on the LX on v3! Ethernet, USB, etc. --
> it's all working.
>
> We may be close to moving all LX boards to v3. This is a big day.
>
> patch attached.
>
> ron


Awesome!

One thing I think you missed:

Index: arch/x86/archtables.c
> ===================================================================
> --- arch/x86/archtables.c    (revision 581)
> +++ arch/x86/archtables.c    (working copy)
> @@ -79,8 +79,13 @@
>      post_code(POST_STAGE2_ARCH_WRITE_TABLES_ENTER);
>
>      /* This table must be betweeen 0xf0000 & 0x100000 */
> -//    rom_table_end = write_pirq_routing_table(rom_table_end);
> -//    rom_table_end = (rom_table_end + 1023) & ~1023;
> +    /* we need to make a decision: create empty functions
> +      * in .h files if the cpp variable is undefined, or #ifdef?
> +      */
> +#ifdef CONFIG_PIRQ_TABLES
> +    rom_table_end = write_pirq_routing_table(rom_table_end);
> +    rom_table_end = (rom_table_end + 1023) & ~1023;
> +#endif


Should be CONFIG_PIRQ_TABLE?

Also, is there copyright info for the pirq routing table files? We should be
preserving that or adding it, it'll never be any easier then right now.

-Corey
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20080209/d2265573/attachment.html>