[coreboot] [PATCH] v3: fix bug in ad-hoc archive finding code in mc146818rtc.c

Stefan Reinauer stepan at coresystems.de
Sun Feb 10 15:22:14 CET 2008


Peter Stuge wrote:
> On Sun, Feb 10, 2008 at 02:27:51PM +0100, Stefan Reinauer wrote:
>   
>>> LAR: Start 0xfff00000 len 0x100000                                                                     
>>> LAR: Start 0xfffc0000 len 0x3c000 <------BUG!                                                          
>>>       
> ..
>
>   
>> So what I don't understand is why only the BUG line really assumes
>> a 256k ROM while all others assume a 1M ROM.
>>     
>
> Actually 256k would be 0x40000 so neither of the two algorithms seem
> to be spot on. :\
Agreed.

The reason it is 16k less was that at the time this code was originally 
written the 16k (back then) bootblock was not part of the lar.

Stefan

-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.dehttp://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20080210/079c3919/attachment.sig>


More information about the coreboot mailing list