[coreboot] patch: more path support

ron minnich rminnich at gmail.com
Wed Feb 13 04:58:08 CET 2008


On Feb 12, 2008 3:02 PM, Corey Osgood <corey.osgood at gmail.com> wrote:
> On Feb 12, 2008 3:15 PM, ron minnich <rminnich at gmail.com> wrote:
>
> >
> > On Feb 12, 2008 11:13 AM, Peter Stuge <peter at stuge.se> wrote:
> > >
> > > >         mainboard-vendor = "Emulation";
> > > >         mainboard-name = "QEMU x86";

Sure, I am fine with that. Comments?


> > > >                         pci at 1,0 {
> > pci at 1,0 --> dev 1 function 0
>
> why shorten device to dev and not fuction to func? is it possible to set it
> up so people/developers can use either dev or device?

I confused you. This line

> pci at 1,0 --> dev 1 function 0
is an explanatory comment. It is not in the dts. Here is the dts again.

/{
        mainboard-vendor = "Emulation";
        mainboard-name = "QEMU x86";
        constructor = "qemuvga_constructors";
        cpus {};
        domain at 0 {
                /config/("northbridge/intel/i440bxemulation/dts");
                bus at 0 {
                        pci at 0,0 {
                        };
                        pci at 1,0 {
                                /config/("southbridge/intel/i82371eb/dts");
                        };
                };
        };
};


That's the whole file.

Let's try to bring this to closure. The score so far.

Stepan: is ok with '@' syntax (as are segher etc. )
Ron: is not that concerned either way as long as an alternative
carl-daniel, peter, corey: do not like @ syntax but need to propose a
reasonable alternative (they have tried but not totally there yet)
which does not make the parser hard to modify.

ron




More information about the coreboot mailing list