[coreboot] [PATCH] v3: Kill dead code

ron minnich rminnich at gmail.com
Thu Feb 14 17:55:39 CET 2008


Acked-by: Ronald G. Minnich <rminnich at gmail.com>


On Wed, Feb 13, 2008 at 3:03 PM, Carl-Daniel Hailfinger
<c-d.hailfinger.devel.2006 at gmx.net> wrote:
> Kill dead code inside #if 0.
>
>
>  The code was blindly copied from v2 in v3:r69. Was never enabled in v2
>  (committed as dead code by Eric Biederman in v2:r1664 with log message
>  "Updates for 64bit resource support, handling missing devices and cpus
>  in the config file").
>
>  Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
>
>  Index: LinuxBIOSv3-if0crud-next/device/pci_device.c
>  ===================================================================
>  --- LinuxBIOSv3-if0crud-next/device/pci_device.c        (Revision 596)
>  +++ LinuxBIOSv3-if0crud-next/device/pci_device.c        (Arbeitskopie)
>  @@ -247,19 +247,6 @@
>         if (resource->limit > limit) {
>                 resource->limit = limit;
>         }
>  -#if 0
>  -       if (resource->flags) {
>  -               printk(BIOS_DEBUG, "%s %02x ->",
>  -                      dev_path(dev), resource->index);
>  -               printk(BIOS_DEBUG,
>  -                      " value: 0x%08llx zeroes: 0x%08llx ones: 0x%08llx attr: %08lx\n",
>  -                      value, zeroes, ones, attr);
>  -               printk(BIOS_DEBUG,
>  -                      "%s %02x -> size: 0x%08llx max: 0x%08llx %s\n ",
>  -                      dev_path(dev), resource->index, resource->size,
>  -                      resource->limit, resource_type(resource));
>  -       }
>  -#endif
>
>         return resource;
>   }
>
>
>  --
>  http://www.hailfinger.org/
>
>
>  --
>  coreboot mailing list
>  coreboot at coreboot.org
>  http://www.coreboot.org/mailman/listinfo/coreboot
>




More information about the coreboot mailing list