[coreboot] v3: dts and arrays

Marc Jones Marc.Jones at amd.com
Thu Feb 14 23:16:24 CET 2008


Stefan Reinauer wrote:
> Carl-Daniel Hailfinger wrote:
>
>> Index: southbridge/amd/cs5536/dts
>> ===================================================================
>> --- southbridge/amd/cs5536/dts    (Revision 590)
>> +++ southbridge/amd/cs5536/dts    (Arbeitskopie)
>> @@ -57,4 +57,7 @@
>>      com2_enable = "0";
>>      com2_address = "0x2f8";
>>      com2_irq = "3";
>> +
>> +    /* Disable unwanted virtualized PCI devices */
>> +    unwanted_vpci[0] = "0";
>>  };
>>
>>   
> I am blissfully ignorant on the topic, but the first thing I wondered:
>
> Should a virtual device not be disabled in the same way as a physical 
> one?
>
> pci at 0,0 {
>    disabled;
> }
>
> ?
>
> Stefan
>
This is an interesting idea but the devices are CS5536 specific and I 
don't think we want to make dts CS5536 aware. I think it better use the 
device ID rather than the device location to do the disable.

Marc

-- 
Marc Jones
Senior Firmware Engineer
(970) 226-9684 Office
mailto:Marc.Jones at amd.com
http://www.amd.com/embeddedprocessors 







More information about the coreboot mailing list