[coreboot] Zero compression in v3 patch

Peter Stuge peter at stuge.se
Fri Feb 15 01:15:20 CET 2008


On Thu, Feb 14, 2008 at 10:13:16AM -0700, Myles Watson wrote:
> I left the one byte so that the checksum wouldn't be broken.

This is important. Please add a comment in do_zeroes_compress().


> +++ include/lar.h	(working copy)
> @@ -67,6 +67,7 @@
>  	 * 0 = no compression
>  	 * 1 = lzma
>  	 * 2 = nrv2b
> +	 * 3 = zeroes

I would really like a more generic RLE version that copes with any
repeated byte value. It will be dirt simple, not much code and no
dependecies, thus always included.

Possibly lar should even try to autodetect suitable candidates for
RLE compression. But note that the flashfiller file is a special
case that must never be RLE compressed.


//Peter




More information about the coreboot mailing list