[coreboot] r593 -

[Peter Stuge]

On Thu, Feb 14, 2008 at 05:48:01PM -0800, ron minnich wrote:
> This is not signed off yet, but is close. 
> 
> It also boots qemu just fine, which is a good sign. 

Great!


> Note that from now on, to pull a constructor into the coreboot
> image and make it available, some dts somewhere has to name it.

I think this is a very safe and reasonable behavior. :)


> I am almost certain we can now completely remove all the domainid,
> pciid, and such ugly stuff.
> Comments welcome.

Please do those removes in the same patch.
(And some are..)


> +++ southbridge/amd/cs5536/dts	(working copy)
> @@ -19,8 +19,7 @@
>   */
>  
>  {
> -	constructor = "cs5536_constructors";
> -	pciid = "PCI_VENDOR_ID_AMD,PCI_DEVICE_ID_AMD_CS5536_ISA";

..like here. \o/

> +++ northbridge/amd/geodelx/domain	(working copy)
> @@ -19,7 +19,6 @@
>   */
>  
>  {
> -	constructor = "geodelx_north_constructors";
> -	domainid = "PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_LXBRIDGE";

..and here.

> +++ northbridge/intel/i440bxemulation/domain	(working copy)
> @@ -20,6 +20,6 @@
>  
>  {
>  	ramsize = "128";
> -	constructor = "i440bx_constructors";
> +	constructor = "i440bx_domain";
>  	domainid = "0x8086, 0x7190";

..but not here.


>  		if (!strncmp(tree->name, "lpc", 3)){
> -			fprintf(f, "\t.path = {.type=DEVICE_PATH_SUPERIO,.u={.superio={.iobase=%s}}},\n", 
> +			fprintf(f, "\t.path = {.type=DEVICE_PATH_LPC,.u={.lpc={.iobase=%s}}},\n", 
>  				path);
>  		}

So the LPC/SUPERIO thing got in the middle of this.

Please have those changes be a separate patch.


Looks very good!


//Peter